Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused log4j jar file from distribution #482

Open
kevinphippsstfc opened this issue Jan 27, 2022 · 0 comments
Open

Remove unused log4j jar file from distribution #482

kevinphippsstfc opened this issue Jan 27, 2022 · 0 comments

Comments

@kevinphippsstfc
Copy link

The topcat war file in the distribution zip file contains the log4j (version 1) jar file. Whilst not as serious as the original exploit on log4j version 2, there have since been a few flaws found in version 1. The latest of these was related to the "chainsaw" functionality it contains.

I don't understand why the log4j jar file is in the final distribution at all because it is a dependency of one of the test dependencies but anyway it is there and should be removed to be completely safe. TopCAT does not use this for logging as it uses logback.

It is unlikely that a new version of TopCAT will be released because it is currently being replaced by DataGateway, so for now the mitigation for this is to remove the log4j jar file from the war file and then redeploy TopCAT.

To do this:

  • Navigate to the directory where the TopCAT distribution zip file was unzipped
  • Run the following command to remove the log4j jar file from the topcat war file zip -d topcat-2.4.8.war WEB-INF/lib/log4j-1.2.13.jar
  • Redeploy TopCAT with ./setup install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant