We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remove the dependency react-router-dom completely from your project.
react-router-dom
The only import in your source code that points to react-router-dom is actually part of react-router.
react-router
In your tests you can easily replace the imported NavLink with an "a" tag. I have a PR ready, but you're currently not allowing to provide PRs.
NavLink
And please don't forget to remove the corresponding peer dependency in your package.json.
package.json
The text was updated successfully, but these errors were encountered:
Hey @fdc-viktor-luft, I'll look into it!
PRs should be allowed, you can't submit one?
Sorry, something went wrong.
Dependency has been removed in 3.2.8
3.2.8
Maybe I did something wrong when pushing my PR. But your PR looked very similar to mine. The only left differences:
rollup.config.js
globals
But nevertheless thank you for your fast response and fix 👍
Thanks @fdc-viktor-luft! I'll remove those other instances shortly
Successfully merging a pull request may close this issue.
Please remove the dependency
react-router-dom
completely from your project.The only import in your source code that points to
react-router-dom
is actually part ofreact-router
.In your tests you can easily replace the imported
NavLink
with an "a" tag. I have a PR ready, but you're currently not allowing to provide PRs.And please don't forget to remove the corresponding peer dependency in your
package.json
.The text was updated successfully, but these errors were encountered: