Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary peer dependency on react-router-dom #102

Closed
fdc-viktor-luft opened this issue Apr 1, 2020 · 4 comments · Fixed by #103 or #104
Closed

Unnecessary peer dependency on react-router-dom #102

fdc-viktor-luft opened this issue Apr 1, 2020 · 4 comments · Fixed by #103 or #104
Labels
dependencies Pull requests that update a dependency file

Comments

@fdc-viktor-luft
Copy link

Please remove the dependency react-router-dom completely from your project.

The only import in your source code that points to react-router-dom is actually part of react-router.

In your tests you can easily replace the imported NavLink with an "a" tag. I have a PR ready, but you're currently not allowing to provide PRs.

And please don't forget to remove the corresponding peer dependency in your package.json.

@icd2k3
Copy link
Owner

icd2k3 commented Apr 1, 2020

Hey @fdc-viktor-luft, I'll look into it!

PRs should be allowed, you can't submit one?

@icd2k3 icd2k3 added the dependencies Pull requests that update a dependency file label Apr 1, 2020
@icd2k3
Copy link
Owner

icd2k3 commented Apr 1, 2020

Dependency has been removed in 3.2.8

@fdc-viktor-luft
Copy link
Author

Maybe I did something wrong when pushing my PR. But your PR looked very similar to mine. The only left differences:

  • In your package.json you forgot to remove the dev dependency "@types/react-router-dom"
  • In your rollup.config.js you can remove "react-router-dom" from your globals

But nevertheless thank you for your fast response and fix 👍

@icd2k3
Copy link
Owner

icd2k3 commented Apr 2, 2020

Thanks @fdc-viktor-luft! I'll remove those other instances shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
2 participants