Support version on waitForServices

[imatefx]

If a service has version waitForServices() function was not able to find the service because the version is undefined when passed to registry.hasService()

it checks if the version can be extracted from the service names with format

v1.accounts
v2.users

[coveralls]

Coverage decreased (-0.04%) to 98.541% when pulling 81de8c6 on imatefx:develop into 0eadc11 on ice-services:master.

[icebob]

Thanks, but current solution works only with numeric version.
We should support all options, e.g.:

• v3.users
• staging.users
• v2.order.saga
  ...etc

Would be better to set an object if you want to define version.

Normal current format

waitForServices("users");
waitForServices(["posts", "users"]);

New optional versioned format

waitForServices({ name: "users", version: "staging" });
waitForServices([{ name: "order.saga", version: 2 }, {name: "users", version: "staging"]);

Both format should be supported.

And of course please add relevant test cases too. We make an effort to cover all codes to ensure stability & quality codebase.

Could you change it?

[imatefx]

ok, i will change it

[coveralls]

Coverage increased (+0.0006%) to 98.585% when pulling 17db54f on imatefx:develop into 0eadc11 on ice-services:master.

[coveralls]

Coverage increased (+0.0006%) to 98.585% when pulling 17db54f on imatefx:develop into 0eadc11 on ice-services:master.

[coveralls]

Coverage increased (+0.0006%) to 98.585% when pulling 2da950c on imatefx:develop into 0eadc11 on ice-services:master.

[imatefx]

I saw your edit only few minutes back 😄 , Added tests

[icebob]

Perfect PR! Thanks!

[icebob]

Nice job! Thank you! 👍

[imatefx]

😄 Thats my contribution to Open Source after a long time 👍

[icebob]

Released in v0.11.2