Ice berg feature 3 #3
Conversation
There was a problem hiding this comment.
Hi @ice949 👋,
Good job so far!
Highlights
- Created a new file to contain functions for changing the status of tasks and clearing all completed tasks 💯
- Uses the
filtermethod 💯 - Updates the
localStoragewhenever an action is taken 💯
However, there are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
Kindly check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider the optional suggestion I made under the review. 👍
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
README.md
Outdated
| ### [Lighthouse](https://developers.google.com/web/tools/lighthouse) | ||
| ## 🤝 Contributing | ||
|
|
||
| An open-source, automated tool for improving the quality of web pages. It has audits for performance, accessibility, progressive web apps, SEO and more. | ||
| Contributions, issues, and feature requests are welcome! | ||
|
|
||
| You can get the Lighthouse report by any of the following ways: | ||
| Feel free to check the [issues page](../../issues/). |
There was a problem hiding this comment.
- Kindly include commands for cloning, installing and starting this project on the development server. This will assist people to know how to clone and start your application without hassle.
Hint:
git clone <url>
cd <name of repository>
npm install
npm start| const editCheckBox = (ID, event) => { | ||
| List.forEach((element) => { | ||
| if (element.index === ID) { | ||
| element.completed = event; | ||
| } | ||
| localStorageTasks(List); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
- [Optional] It would be nice to strike through the task when you toggle the checkbox. This will improve the user experience of your application. The reason why I say this is because when I click the checkbox and reload the page, I only get to see that the status changed by looking at the
localStoragein the browser. Kindly implement this feature. 👍
There was a problem hiding this comment.
Hi @ice949, 👋🏻👋🏻
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- No Linters error 🔥✅✅
- Good working on the requested changes ✅✅
Optional suggestions
[OPTIONAL ] It would be nice to strike through the task when you toggle the checkbox. This will improve the user experience of your application. The reason why I say this is because when I click the checkbox and reload the page, I only get to see that the status changed by looking at the localStorage in the browser. Kindly implement this feature. 👍
[ HINT ] you can check the toggling condition here so you just toggle from the true to false :
if (arrayOfTasks[i].id === +taskId) { // +to make it numbers
arrayOfTasks[i].completed = !arrayOfTasks[i].completed;
}
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
To Do list: interactive list
New Features