You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I'm always frustrated when coding in llh.py, because many things are nearly identical/redundant.
Describe the solution you'd like
A rationalisation, where the standard matrix method is used as default. Ideally, the 'standard' likelihood method would be removed entirely, but then things won't play nice with fitting_weights and flares. So it'd take some work.
Describe alternatives you've considered
Partially renaming things but maintaining separate implementations. It's easier in the short term, but more cumbersome to maintain.
Additional context
Flarestack will give nonsensical results if sources overlap under the default 'standard', but works fine with matrices. This is dangerous default behaviour. Changing names would probably lead to a change where old configs do not work anymore, or do different things.
The text was updated successfully, but these errors were encountered:
Issue #245 is likely related to what is reported in this issue.
It should be noted that llh.py lacks good documentation in general, as the distinction between 'standard', 'standard_overlapping' and 'standard_matrix' is not clear.
So I think this is basically the way to go. For flare stacking and fitting weights, you need standard llh. This could perhaps be renamed to isolated_sources llh. Then for everything else, I think you need standard matrix, which basically does everything properly, and should perhaps be renamed full_matrix_llh or something like that. I think standard_overlapping is just a slower/original version of the matrix method, and is perhaps completely useless.
Is your feature request related to a problem? Please describe.
I'm always frustrated when coding in llh.py, because many things are nearly identical/redundant.
Describe the solution you'd like
A rationalisation, where the standard matrix method is used as default. Ideally, the 'standard' likelihood method would be removed entirely, but then things won't play nice with fitting_weights and flares. So it'd take some work.
Describe alternatives you've considered
Partially renaming things but maintaining separate implementations. It's easier in the short term, but more cumbersome to maintain.
Additional context
Flarestack will give nonsensical results if sources overlap under the default 'standard', but works fine with matrices. This is dangerous default behaviour. Changing names would probably lead to a change where old configs do not work anymore, or do different things.
The text was updated successfully, but these errors were encountered: