Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional seed in MillipedeWilks traysegment #246

Open
mlincett opened this issue Dec 1, 2023 · 0 comments
Open

Optional seed in MillipedeWilks traysegment #246

mlincett opened this issue Dec 1, 2023 · 0 comments

Comments

@mlincett
Copy link
Collaborator

mlincett commented Dec 1, 2023

The current MillipedeWilks reco traysegment takes an optional seed:

if seed is not None:
logger.debug('Updating StepXYZ')
self.UpdateStepXYZ(coars_steps, seed.dir, 150*I3Units.m)
self.UpdateStepXYZ(finer_steps, seed.dir, 3*I3Units.m)

Currently, that argument is hardcoded to:

seed=pframe[f"{cfg.OUTPUT_PARTICLE_NAME}"],

It seems to me that we can get rid of the additional argument, and just default to updating the steps according to cfg.OUTPUT_PARTICLE_NAME (?)

@tianluyuan I am taking care of this as part of #244 since I have to modify the traysegment arguments nevertheless. Let me know if you have comments.

I see this is a bit more tricky than I thought, because the "steps" live at the segment instance scope, while the frame is accessible only when the segment is run. Probably the most idiomatic way of doing this would be to store the steps inside the frame? This goes a bit beyond the scope of #244 and is rather connected to #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant