Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI Tests (Compare Outputs) #34

Closed
ric-evans opened this issue Jun 9, 2022 · 3 comments · Fixed by #55
Closed

Add CI Tests (Compare Outputs) #34

ric-evans opened this issue Jun 9, 2022 · 3 comments · Fixed by #55
Assignees
Labels
enhancement New feature or request

Comments

@ric-evans
Copy link
Member

ric-evans commented Jun 9, 2022

Let's add tests that will compare outputs to known outputs, for a mini-scale run.

Steps:

  1. Run full-scale on HTCondor cluster (Full-Sized Scan Test Run on Condor #35) and compare/confirm results (a la Scan result to single numerical file #40) to known results from python/-version
  2. Run mini-scale on CI (already implemented) and persist outputs
  3. Add CI Test(s): Compare persisted mini-scale outputs against CI

When this is complete we can remove test-case-scan/, since all its code will be integrated into skymap_scanner/ and tests/.

@ric-evans ric-evans self-assigned this Jun 9, 2022
@ric-evans ric-evans added the enhancement New feature or request label Jun 9, 2022
@ric-evans
Copy link
Member Author

ric-evans commented Jun 22, 2022

Also, don't run the CI on "tags" (so we don't get near the org limit of 60 concurrent jobs):

on:
  push:
    branches:
      - '**'
    tags-ignore:
      - '**'

@ric-evans
Copy link
Member Author

ric-evans commented Jun 22, 2022

waiting on #40

Done

@ric-evans
Copy link
Member Author

ric-evans commented Jun 28, 2022

waiting for #46

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant