-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
column macro possibly in conflict with core column macro #2306
Comments
This is most likely a Try updating it. |
I don't like abbreviations. I think they add subconscious overhead and increase the learning barrier. |
Thanks for the tip. I actually don't think I can do anything for that, because I think its built in the RustRover, there is no option or plugin like this. Anyway this issue is rather about evaluating whether it would be a good idea to rename the column macro 😊
Some abbreviations are well established, like e.g. col, though :) |
I see! We use issues for bug reports only. I recommend you to start a discussion either over our Discord server or our Discourse forum. Closing, since this isn't really a bug! |
Understood, I should have realized, my appologies :) And thank you |
Is there an existing issue for this?
Is this issue related to iced?
What happened?
In RustRover (new ide for rust from JetBrains), the macro in iced_widget::column collides (probably) with core::column macro and causes issues with code navigation and highlighting (screenshot below). While this is not an issue of Iced itself, I would suggest to avoid these macros to have the same name (or any macros to be named the same as the core macros) as it may have unintended consequences now and in the future.
For simplicity I would suggest to rename the macro to "col" as it would pair nicely with "row" as a short macro. This abbreviation is well known between other languages (like HTML) as well.
Do not get me wrong, I think short but full names have their merit, but there are cases like this where I think it would be prudent to avoid it.
I have just filed this bug to Jetbrains. Feel free to look at it in detail as it includes also a minimal example and following screenshot:
What is the expected behavior?
There are no side effects of this same naming.
Version
crates.io release
Operating System
Linux
Do you have any log output?
No response
The text was updated successfully, but these errors were encountered: