-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Download, serialized data passed to the Worker exceedes the max size allowed (Solution: only pass songId instead of full object) #24
Comments
what caused this issue exactly? Would be great if I could reproduce it. |
Beside the steps, I also need to know what happens next. |
Looks fixed from 0.08 onwards |
I'm going to reopen this, from the crash trace I received yesterday night looks like it's still happening silently and that's what causing issues with downloads, at least from what I see in the logs.
|
I see downloads are not crashing the app but some songs will not download and stop the process. I've tested a few times on my lists. 4-8 songs usually and then a stop. Could that error be a cause too? Will this error show up on Android studio if i load in there? |
That issue should have been fixed on 0.10-beta. If you're on that version then the problem doesn't seem to be solved, and I'll look into it again. The log won't who show if you connect to android studio because the exception is caught without outputting any log on production releases. But you could go to Settings and enable remote logging and I will get a log of the exception. |
I think this one would be limiting the length of the url. Which is good because 3300 song ids would definitely be too long to send
The text was updated successfully, but these errors were encountered: