You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When fixing the generator (patchs.go fixes), a contributor needs to build the local patched version.
However go build -o generator github.com/IceflowRE/go-wargaming/v4/tools/generator (like instructed in the README) will build the unpatched version from the upstream repository, not the local checkout.
It's possible to build the generator locally (go build -o generator tools/_generator/main.go, but it has other side effects, mainly messing-up the imports:
// realm:
-// Valid realms: RealmAsia, RealmEu, RealmNa+//+// Valid realms: RealmAsia, RealmEu, RealmNa+//
// search:
-// Player name search string. Parameter "type" defines minimum length and type of search. Using the exact search type, you can enter several names, separated with commas. Maximum length: 24.+//+// Player name search string. Parameter "type" defines minimum length and type of search. Using the exact search type, you can enter several names, separated with commas. Maximum length: 24.
My go version:
> go version
go version go1.19.8 linux/amd64
The text was updated successfully, but these errors were encountered:
I could not reproduce the local build failure.
If i do
go build -o generator github.com/IceflowRE/go-wargaming/v4/tools/_generator
it will build from the local version.
Probably you had the newest version and did
go build -o generator github.com/IceflowRE/go-wargaming/v4/tools/generator
Note the missing underscore. I added the underscore, that the tools wont be delivered when doing go get. This might have been the issue here.
Will update the readme.
When fixing the generator (patchs.go fixes), a contributor needs to build the local patched version.
However
go build -o generator github.com/IceflowRE/go-wargaming/v4/tools/generator
(like instructed in the README) will build the unpatched version from the upstream repository, not the local checkout.It's possible to build the generator locally (
go build -o generator tools/_generator/main.go
, but it has other side effects, mainly messing-up the imports:Put also adding
//
spacing comment lines:My go version:
> go version go version go1.19.8 linux/amd64
The text was updated successfully, but these errors were encountered: