Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive with bloom filter? #9

Closed
dolaor opened this issue Mar 15, 2021 · 1 comment
Closed

false positive with bloom filter? #9

dolaor opened this issue Mar 15, 2021 · 1 comment

Comments

@dolaor
Copy link

dolaor commented Mar 15, 2021

Hi,

I think that the last version of your code which includes the bloom filter can return false positive private key since bloom filter is a probabilistic data structure. So I am not sure if it is relevant to include it in the code. What do you think about it?

@iceland2k14
Copy link
Owner

Yes Correct. Althought i used probability of False +ve of 10^-9.
But still it was giving some collisions. I fixed it now, by updating the version. Also the bPfile.bin is required now, but only a very small portion of it is read. So no imprint in memory. Hope it fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants