Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: set ssh2 dependency to ^0.5 to enable ECDSA/ECDH support #445

Closed
Darkspirit opened this issue Aug 13, 2016 · 4 comments
Closed

Comments

@Darkspirit
Copy link

Darkspirit commented Aug 13, 2016

https://github.com/mscdex/ssh2/wiki/Changes-from-0.4.x-to-0.5.x

  • Support for ECDH for key exchange (node v0.12+).
  • Support for ECDSA keys (both for server host keys and private keys for user authentication) (node v5.2.0+).

In our /etc/ssh/sshd_config (OpenSSH on Ubuntu 16.04 server) we have:
HostKey /etc/ssh/ssh_host_ecdsa_key
# generated with ssh-keygen -t ecdsa -b 521 -N "" -o -f /etc/ssh/ssh_host_ecdsa_key

KexAlgorithms ecdh-sha2-nistp521
Ciphers aes256-gcm@openssh.com,chacha20-poly1305@openssh.com
MACs hmac-sha2-512-etm@openssh.com

@Darkspirit
Copy link
Author

Darkspirit commented Aug 13, 2016

But #325 could be still a problem. (I don't know.)

(Only) With the latest stable Atom, I am able to connect to my server, if
i change ssh2 to "^0.5" in ~/.atom/packages/Remote-FTP/package.json,
run "apm install" in that folder (to load ssh2 0.5.0),
set hosthash to sha1 in .ftpconfig,
and change my sshd_config to "MACs hmac-sha2-512-etm@openssh.com,hmac-sha2-512".

I tried to set ssh2 to *, but then "apm install" wont load anything (=no 0.5.0)

Atom : 1.9.8
Electron: 0.37.8
Chrome : 49.0.2623.75
Node : 5.10.0

@Darkspirit Darkspirit changed the title packages.json "ssh2": "^0.4" ----> ^0.5 to enable ECDSA/ECDH support (urgent), don't want to weaken sshd config packages.json "ssh2": "^0.4" ----> ^0.5 to enable ECDSA/ECDH support Aug 13, 2016
@Darkspirit Darkspirit changed the title packages.json "ssh2": "^0.4" ----> ^0.5 to enable ECDSA/ECDH support packages.json: set ssh2 dependency back to "*" to enable ECDSA/ECDH support Aug 13, 2016
@Darkspirit Darkspirit changed the title packages.json: set ssh2 dependency back to "*" to enable ECDSA/ECDH support package.json: set ssh2 dependency back to "*" to enable ECDSA/ECDH support Aug 13, 2016
@Darkspirit Darkspirit changed the title package.json: set ssh2 dependency back to "*" to enable ECDSA/ECDH support package.json: set ssh2 dependency to ^0.5 to enable ECDSA/ECDH support Aug 13, 2016
@jimmaaay
Copy link
Collaborator

Hey I'll have a look and see what I can do.

@jimmaaay
Copy link
Collaborator

Just to let you know it may take a while as I will need to setup some tests to make sure that this does not recreate the issue #325

@jimmaaay
Copy link
Collaborator

@terrax-net This should work now in 0.9.2. As ssh2 has dependency has been set to ^0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants