Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to WebContentsView from BrowserView #248

Closed
icewolfz opened this issue Dec 27, 2023 · 2 comments · Fixed by #260
Closed

Move to WebContentsView from BrowserView #248

icewolfz opened this issue Dec 27, 2023 · 2 comments · Fixed by #260
Labels
enhancement A new feature or way to improve a current feature to make it better or offer more uses

Comments

@icewolfz
Copy link
Owner

Need to look into moving from BrowserView to WebContentsView as BrowserView has been deprecated and web view is the new replacement, need to test and see if it is a simple replacement or will require total recode of the window systems

@icewolfz icewolfz added the enhancement A new feature or way to improve a current feature to make it better or offer more uses label Dec 27, 2023
@icewolfz
Copy link
Owner Author

This will not land until 29 so can not begin moving to it until upgraded to electron 29, browserview will probably be removed in 30 or later as electron tends to remove stuff 1 or 2 version after being marked deprecated, but by the looks of it should be not to hard to convert to webcontentviews they work very much like browserviews, main issue may need to convert to base window and create a manager view for each window unlike how the current system uses the main window as the manager for tabs

@icewolfz icewolfz changed the title Move to WebContentsView from BrowswerView Move to WebContentsView from BrowserView Apr 18, 2024
@icewolfz
Copy link
Owner Author

Electron 30 breaks BrowserView so this is required now to move to newer electrons as BrowserView is depreciated i doubt they will fix the issue since the WebContentsView seems to lack the bug, and i bet 31 or 32 will remove BrowserView if not in later versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or way to improve a current feature to make it better or offer more uses
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant