New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When I give empty data, an empty row appears #138
Comments
I'm sorry, but I am unable to reproduce. Try setting a If you still think there's a problem, please provide a working example (on codesandbox or something like that)... |
I am sharing the codesandbox link below. When you inspect the table, you will see an empty row and an empty column appear. I noticed that when I use Tailwind, it gives a border to the empty column, so I'm having such a problem. |
The provided sandbox is not functional: But, since you've mentioned tailwind, I think I understand what the problem might be. TL;DRSee if scoping tailwind helps. ExplanationAs you know, the component is built upon (and intended to be used in conjunction with) Mantine, an excellent UI library that follows healthy CSS scoping/encapsulation principles. Tailwind, on the other hand, does not, and therefore doesn't play nice with UI component libraries. It's not necessarily bad per se (you could probably use it with their paid UI components), but if you ask me, it gives you the false impression that you don't actually need to know CSS, ir creates more problems than it solves and in the end it promotes bad practices. That is why I'm getting more and more biased against it nowadays. seeing how it's thoughtlessly adopted without considering the implications. We could, arguably, do more in Mantine DataTable to increase our styling selectors specificity. But, in doing so, we'd end up adding unnecessary bloat to our library in order to accommodate unwanted side-effects generated by tailwind or other things that do not follow CSS scoping/encapsulation best practices. |
@icflorescu Thank you for your fast response! |
facing same problem |
I created a working stackblitz demonstrating the issue |
Thanks for the stackblitz. |
Describe the bug
When I give empty data, an empty row appears
Screenshots
Desktop (please complete the following information):
Thanks for helps.
The text was updated successfully, but these errors were encountered: