Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for not displaying thead #253

Closed
zbraniecki opened this issue Apr 13, 2023 · 4 comments
Closed

Allow for not displaying thead #253

zbraniecki opened this issue Apr 13, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@zbraniecki
Copy link

Describe the solution you'd like

There are cases, such as nested table, where it would be useful to skip the thead display.

I'm currently workarounding it by setting titleStyle: { display: 'none' } on each column.
@icflorescu icflorescu added the enhancement New feature or request label Apr 13, 2023
@icflorescu
Copy link
Owner

This would be fairly easy to implement.

How would you call the prop?

  • withoutHeader
  • noHeader
  • something else

@zbraniecki
Copy link
Author

I'm not super familiar with React API design, but my guess would be that header: boolean would allow you to later grow that to boolean | Options.

@icflorescu
Copy link
Owner

Went with noHeader in the end.

See examples using this feature:

@icflorescu
Copy link
Owner

Implemented in v2.4.6.

Speaking of React API design, AFAIK it's desirable to have boolean props defaulting to false.
That's partially why I went with noHeader; I'm not a fan of having to specify a prop={false} for a React component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zbraniecki @icflorescu