Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with clang++ #2

Closed
ms705 opened this issue May 21, 2014 · 1 comment
Closed

Build fails with clang++ #2

ms705 opened this issue May 21, 2014 · 1 comment

Comments

@ms705
Copy link
Contributor

ms705 commented May 21, 2014

To integrate with the Firmament build flow, we'll need to build Flowlessly using clang++.

Currently, this fails:

malte@eucleia:~/Projects/firmament/ext/flowlessly-git(git)$ make
  CXX     arc.o
  CXX     cost_scaling.o
  CXX     cycle_cancelling.o
  CXX     graph.o
graph.cc:549:3: warning: control reaches end of non-void function
      [-Wreturn-type]
  }
  ^
graph.cc:838:3: warning: control may reach end of non-void function
      [-Wreturn-type]
  }
  ^
2 warnings generated.
  CXX     statistics.o
  CXX     successive_shortest.o
  CXX     utils.o
utils.cc:143:26: error: variable length array of non-POD element type
      'binomial_heap<pair<int64_t, uint32_t>, compare<greater<pair<int64_t,
      uint32_t> > > >::handle_type' (aka 'node_handle<node_pointer, super_t,
      reference>')
                  handles[num_nodes];
                         ^
1 error generated.
make: *** [utils.o] Error 1

This does not appear to be a trivial fix: the handles array is an array of boost::binomial_heap handle types. Maybe what we should do here is define a vector?

Will look at a patch later, but ideas welcome.

@ICGog
Copy link
Owner

ICGog commented May 23, 2014

Solved.

@ICGog ICGog closed this as completed May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants