Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'd like to make a front-end page for this page. #134

Closed
seanoh1989 opened this issue Sep 22, 2015 · 22 comments
Closed

I'd like to make a front-end page for this page. #134

seanoh1989 opened this issue Sep 22, 2015 · 22 comments

Comments

@seanoh1989
Copy link

The address could be simply awesome-osx.github.io or something like that whatever the repo owner decides to.

The website can be a Bootstrap single page with Jumbotron for header,

and multiple table rows and columns consists of each product. Once user clicks, it will show a modal so the user can stick with the same page.

I have my portfolio website (still under development :p ) at http://saehunseanoh.me and it will look similar to Project section.

anyone interested? then I'll start it from today.

@iCHAIT
Copy link
Owner

iCHAIT commented Sep 22, 2015

@seanoh1989 Hi

I totally like the idea of a web page for the list, was myself interested in making one but couldn't start with it due to lack of time. Though I would reckon before you start off with it, it would be nice to have feedback and suggestion particularly on the design of the page from other developers.

@dufferzafar @herrbischoff

@seanoh1989
Copy link
Author

@iCHAIT complete source code of my web is viewable here and my website framework is inspired by Freelanceer with multiple other libraries like Hover.css.

For the images, I used pixrl and I saved the templete. So it will be easy next time I want to create an image for the projects. And I can absolutely provide that.

Let me know :)

@dufferzafar
Copy link
Collaborator

@seanoh1989 Cool Portfolio.

I'd 👍 this.

@herrbischoff
Copy link
Collaborator

I would keep the site as simple as possible, without any modals, "jumbotrons" or other gimmicks. Bootstrap sounds like the popular go-to framework but it's a pain to modify the components since you need to overwrite the defaults in dozens of places or start meddling with the source files themselves. For me, Bootstrap is a nice solution for quick web apps but not necessarily for websites. I my experience it's more often trouble than not in the long run. Just my two cents.

Also, you'd probably need to leverage a JS Markdown parser, like this: https://github.com/evilstreak/markdown-js, to avoid duplicate data entry.

@seanoh1989: If you'd like a hand, let me know. I build web apps/sites for a living. ;)

@iCHAIT
Copy link
Owner

iCHAIT commented Sep 22, 2015

I agree with @herrbischoff .

@seanoh1989 Maybe you should open a PR, and we can discuss it further, we definitely want to have a web page for the list sooner or later, so I think it would be better to open a PR and discuss it then as to what kind of design we want and what kind of problems we may face.

What do you guys think?

@seanoh1989
Copy link
Author

@herrbischoff Hi! Thanks for the awesome suggestion 👍

However, wouldn't the purpose of the website for people who really don't care about the GitHub page (non-geeky people)? and they wouldn't really be happy with super simple list based website because they do care about design over simplicity+usability. We could always make sample sites for both (bootstrap and markdown parser) and see which one suit more for our purpose.

Also if we do have bootstrap page, I will provide step-by-step tutorial about how to create a product card and modal so we have set template to prevent from the website going everywhere.

@herrbischoff
Copy link
Collaborator

I agree with @iCHAIT. Further discussion makes sense within a PR where we can directly comment on the code. We should work in a separate branch though. Possibly it makes sense that you create it, so we can all check out that branch to review and work on it. Naming suggestion: "website-dev". Later, we can move that branch to the dedicated GitHub Pages branch.

Since it was @seanoh1989's idea, I believe he should initiate the PR. ;)

@seanoh1989
Copy link
Author

@iCHAIT @herrbischoff

Sorry but I'm pretty new to GitHub opensource projects so I need to catch up some abbreviations and conventions. Do you mean PR as Public Repo ? or Pull Request? 😭

@dufferzafar
Copy link
Collaborator

@seanoh1989 Pull Request.

You don't have to be sorry for anything, by the way. We all learn something daily. :)

@herrbischoff
Copy link
Collaborator

@seanoh1989: no sweat. It means Pull Request. Ever done that before?

@seanoh1989
Copy link
Author

No, I haven't. I'm trying to follow this example from here , but it looks like the owner @iCHAIT has to create a branch ? Help me out haha

You guys are awesome 👍

@herrbischoff
Copy link
Collaborator

I believe the easiest way is indeed for @iCHAIT to create a branch. You then fork the repository and clone it locally. Then create a new local branch from that branch and check that out. On the shell you do that with git checkout -b <WEBSITE BRANCH> <YOUR BRANCH>. It will be easiest if you use GitHub desktop for the time being, it makes this simple. You then work and commit in your branch and click on the button on the top right to create a pull request. Make sure that it points from your local branch to the original branch.

I know this probably sounds quite confusing/perplexing but especially in GitHub Desktop it should become self-explanatory after a few tries. Remember, if you mess up, you can always delete the cloned repo and start fresh. :)

@seanoh1989
Copy link
Author

Yes I already cloned the project and made a new branch named website-dev under origin.

I just need to push it but obviously I don't have permission to push it to non-existing branch on the repo :) I'll be waiting!

Btw I use github and/or svn daily so basic stuff like clone,push/pull,add/delete,commit, checkout, and etc are fine with me. Thank you again!

@seisfeld
Copy link

@seanoh1989 You won't be able to push because you don't have write access to origin. You need to initiate a pull request and after discussion @iCHAIT will decide if he merges your branch or not.

@seanoh1989
Copy link
Author

@iCHAIT any update on this? Thanks!

@iCHAIT
Copy link
Owner

iCHAIT commented Sep 27, 2015

@seanoh1989 Sorry for getting such a delay, was really busy for the past few days, I think you should proceed with this and open a PR 👍

@seanoh1989
Copy link
Author

@iCHAIT can you make a new branch so I can do a PR ?

@iCHAIT
Copy link
Owner

iCHAIT commented Sep 29, 2015

@seanoh1989 Created a new branch web-page -

https://github.com/iCHAIT/awesome-osx/tree/web-page

I hope this should get you going.

This was referenced Sep 29, 2015
@seanoh1989
Copy link
Author

@iCHAIT PR created

@herrbischoff
Copy link
Collaborator

@seanoh1989: Any progress with this?

@seanoh1989
Copy link
Author

@herrbischoff the PR has been made, but as I mentioned in the PR, I am having a busy month from my work :'( I'll get back to it as soon as this work gets a little bit lighter! 👍

@herrbischoff
Copy link
Collaborator

@seanoh1989: Since it's been over two months since you declared your interest in building a front end but nothing happened, I just went ahead and built a possible technical foundation. Please see PR #203 for details.

Also, @iCHAIT: please check it out and let me know what you think. :) So far there's practically no design.

@iCHAIT iCHAIT closed this as completed Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants