Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Awesome label #31

Closed
iCHAIT opened this issue Sep 15, 2015 · 15 comments
Closed

Add Awesome label #31

iCHAIT opened this issue Sep 15, 2015 · 15 comments

Comments

@iCHAIT
Copy link
Owner

iCHAIT commented Sep 15, 2015

It would be nice to have an awesome logo for this list.

Maybe something similar to this.

@iCHAIT iCHAIT changed the title Add Awesome logo Add Awesome label Sep 15, 2015
@herrbischoff
Copy link
Collaborator

Just in case you're interested, I have created a very simple type logo with Apple's new San Francisco display font. I will send a pull request in a minute.

@iCHAIT
Copy link
Owner Author

iCHAIT commented Sep 18, 2015

Merged the PR but looks like the label is broken.

@herrbischoff
Copy link
Collaborator

This is weird, because you use the same kind of link for oss.png, which works.

https://github.com/iCHAIT/awesome-osx/blob/master/media/oss.png

vs.

https://github.com/iCHAIT/awesome-osx/blob/master/media/awesome.svg

Since the Awesome spectacles are SVG as well, it also cannot be an embedding problem.

@iCHAIT
Copy link
Owner Author

iCHAIT commented Sep 18, 2015

Yes, indeed I also tried using the img tag instead and it still doesn't works :/

@herrbischoff
Copy link
Collaborator

But opening the direct link previews the file correctly. What the...?

@iCHAIT
Copy link
Owner Author

iCHAIT commented Sep 18, 2015

Looks like it has something to so with SVG's, maybe.

@herrbischoff
Copy link
Collaborator

It shouldn't:

screen shot 2015-09-18 at 14 51 00

@herrbischoff
Copy link
Collaborator

But just for the sake of it, here's the same file exported as a PNG at 3x:

awesome

(Hopefully GitHub won't butcher it...)

@iCHAIT
Copy link
Owner Author

iCHAIT commented Sep 18, 2015

Serving the image via rawgit makes it visible on the readme :/
It is a poor workaround though.

@herrbischoff
Copy link
Collaborator

So it won't even work with the PNG I uploaded above?

@iCHAIT
Copy link
Owner Author

iCHAIT commented Sep 18, 2015

I am not sure, after a little bit of googling I found this -

http://stackoverflow.com/a/21521184

Though I don't know how relevant is this now.

@herrbischoff
Copy link
Collaborator

I see. Good catch! So it appears to be a GitHub issue. If you want, I will open another pull request, removing the SVG and adding the PNG.

@iCHAIT
Copy link
Owner Author

iCHAIT commented Sep 18, 2015

I don't think their is really a need for it. Totally fine with SVG.

Though in case you wanted to dig a little deeper into the issue -

isaacs/github#316

@herrbischoff
Copy link
Collaborator

Interesting, thanks for the link! I will keep that in mind for future occasions.

@iCHAIT
Copy link
Owner Author

iCHAIT commented Sep 18, 2015

👍

@iCHAIT iCHAIT closed this as completed Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants