Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds of v1.7.0 #117

Closed
Jan-E opened this issue Oct 3, 2016 · 8 comments
Closed

Windows builds of v1.7.0 #117

Jan-E opened this issue Oct 3, 2016 · 8 comments

Comments

@Jan-E
Copy link
Contributor

@Jan-E Jan-E commented Oct 3, 2016

@icing I tried to compile v1.7.0 for Windows. To do that, I grabbed the dsp-files from the 2.4.x branch of the Apache sources and created new project files. However, both the VC9 and VC11 builds failed with these errors:

  h2_bucket_beam.c
h2_bucket_beam.c(180): error C2491: 'ap_hook_beam_bucket' : definition of dllimport function not allowed
h2_bucket_beam.c(180): error C2491: 'ap_hook_get_beam_bucket' : definition of dllimport function not allowed
h2_bucket_beam.c(180): error C2491: 'ap_run_beam_bucket' : definition of dllimport function not allowed

I did not try the VC14 build yet, but I guess that one fails as well. If and when I find the solution for this issue I will post it here.

@icing

This comment has been minimized.

Copy link
Owner

@icing icing commented Oct 3, 2016

Arg, no idea what the problem there is. Hope we find a fix. Thanks for looking into this.

@Jan-E

This comment has been minimized.

Copy link
Contributor Author

@Jan-E Jan-E commented Oct 3, 2016

There is something on MSDN:
https://msdn.microsoft.com/en-us/library/62688esh.aspx
However, there is no __declspec(dllimport) anywhere in mod_http2.

Maybe some guys at Apachelounge know the solution:
https://www.apachelounge.com/viewtopic.php?p=34308#34308

@Jan-E

This comment has been minimized.

Copy link
Contributor Author

@Jan-E Jan-E commented Oct 3, 2016

Same error with a VC14 build

@icing

This comment has been minimized.

Copy link
Owner

@icing icing commented Oct 4, 2016

Could you kindly check if https://github.com/icing/mod_h2/releases/tag/v1.7.1 fixes the issues?

@Jan-E

This comment has been minimized.

Copy link
Contributor Author

@Jan-E Jan-E commented Oct 4, 2016

Closing in. I am getting 192 unresolved externals at linking time, but that is probably something that has to be solved in the VC project files. I do not have the time to resolve this at the moment, but maybe Steffen of Apachelounge has.

Examples of the missing externals:

h2_bucket_eoc.obj : error LNK2001: unresolved external symbol _apr_bucket_shared_copy
h2_bucket_eos.obj : error LNK2001: unresolved external symbol _apr_bucket_shared_copy
h2_filter.obj : error LNK2001: unresolved external symbol _apr_bucket_shared_copy
h2_bucket_beam.obj : error LNK2019: unresolved external symbol __imp__apr_pool_pre_cleanup_register@12 referenced in function _h2_beam_create
h2_bucket_eoc.obj : error LNK2001: unresolved external symbol __imp__apr_pool_pre_cleanup_register@12
h2_bucket_eos.obj : error LNK2001: unresolved external symbol __imp__apr_pool_pre_cleanup_register@12
h2_session.obj : error LNK2001: unresolved external symbol __imp__apr_pool_pre_cleanup_register@12
h2_bucket_beam.obj : error LNK2019: unresolved external symbol __imp__apr_pool_cleanup_kill@12 referenced in function _h2_beam_destroy
h2_bucket_eos.obj : error LNK2001: unresolved external symbol __imp__apr_pool_cleanup_kill@12
h2_session.obj : error LNK2001: unresolved external symbol __imp__apr_pool_cleanup_kill@12
h2_session.obj : error LNK2001: unresolved external symbol __imp__apr_snprintf
h2_util.obj : error LNK2001: unresolved external symbol __imp__apr_snprintf

@icing

This comment has been minimized.

Copy link
Owner

@icing icing commented Oct 4, 2016

Looks like the apr_/apr-util_ stuff is no longer found at link time. The h2_bucket_eoc.c has not been touched in recent releases, for example.

@Jan-E

This comment has been minimized.

Copy link
Contributor Author

@Jan-E Jan-E commented Oct 4, 2016

Yeah, that is probably caused by recreating the VC project files from the dsp's.

@Jan-E

This comment has been minimized.

Copy link
Contributor Author

@Jan-E Jan-E commented Oct 4, 2016

I took the previous project files once again, removed h2_response, added h2_headers and the compilation went fine.

@Jan-E Jan-E closed this Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.