Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible optimization in h2_c2_create() #274

Open
mkauf opened this issue Jan 11, 2024 · 0 comments
Open

Possible optimization in h2_c2_create() #274

mkauf opened this issue Jan 11, 2024 · 0 comments

Comments

@mkauf
Copy link
Contributor

mkauf commented Jan 11, 2024

The function h2_c2_create() takes a bucket allocator as a parameter (apr_bucket_alloc_t *buckt_alloc), but this parameter is not used.

The function creates a new bucket allocator:

c2->bucket_alloc           = apr_bucket_alloc_create(pool);

It could be an optimization to use the bucket allocator that has been passed as a parameter:

c2->bucket_alloc           = buckt_alloc;

I don't know whether this is correct - feel free to close this issue if it's a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant