Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #12047] Key Escapes in InfluxDB Writer Don't Work #4329

Closed
icinga-migration opened this issue Jun 27, 2016 · 2 comments
Closed
Labels
area/metrics General metrics handling bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12047

Created by spjmurray on 2016-06-27 09:35:23 +00:00

Assignee: spjmurray
Status: Closed (closed on 2016-06-27 10:09:04 +00:00)
Target Version: 2.5.0
Last Update: 2016-06-27 10:09:04 +00:00 (in Redmine)

Icinga Version: 2.5.0
Backport?: Not yet backported
Include in Changelog: 0

Simple case of returning the wrong variable from the key escape function, the shame!

Attachments

Changesets

2016-06-27 10:07:07 +00:00 by spjmurray c6add53

Fix InfluxDB Writer Key Escaping

The escaping wasn't being performed on measuerments, keys or tag values.  The
escape function was returning the input and not the modified ouput, so this
has been fixed

refs #12047

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
@icinga-migration
Copy link
Author

Updated by spjmurray on 2016-06-27 09:39:38 +00:00

  • File added 0001-Fix-InfluxDB-Writer-Key-Escaping.patch

From 0a2cc0bd39be94a7fa8c253a2ebae37e4e26f16f Mon Sep 17 00:00:00 2001
From: Simon Murray <spjmurray@yahoo.co.uk>
Date: Mon, 27 Jun 2016 10:38:07 +0100
Subject: [PATCH] Fix InfluxDB Writer Key Escaping

The escaping wasn't being performed on measuerments, keys or tag values. The
escape function was returning the input and not the modified ouput, so this
has been fixed

refs #12047

And yes it has been tested this time :)

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-06-27 10:09:04 +00:00

  • Status changed from New to Closed
  • Assigned to set to spjmurray
  • Target Version set to 2.5.0
  • Done % changed from 0 to 100
  • Include in Changelog changed from 1 to 0

Applied thanks.

@icinga-migration icinga-migration added bug Something isn't working area/metrics General metrics handling labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.5.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics General metrics handling bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant