Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerfData: Server Timeouts for InfluxDB Writer #4941

Closed
wants to merge 1 commit into from
Closed

PerfData: Server Timeouts for InfluxDB Writer #4941

wants to merge 1 commit into from

Conversation

spjmurray
Copy link
Contributor

Exposes the TCP socket used to communicate with the InfluxDB server. When we are
expecing a response we can now call poll() on the socket to wait for data to become
available. If it doesn't in a user configurable timeout period we abort the request.

Refs #4927

@spjmurray
PerfData: Server Timeouts for InfluxDB Writer
331b255 
Exposes the TCP socket used to communicate with the InfluxDB server.  When we are
expecing a response we can now call poll() on the socket to wait for data to become
available.  If it doesn't in a user configurable timeout period we abort the request.

Refs Icinga#4927
@spjmurray
Copy link
Contributor Author

spjmurray commented Jan 20, 2017 •
edited

Debatable whether I should use boost::tuple and boost::tie versus just setting a reference, but I'll let you argue over it. Also, yey for github, welcome to the party 🦄

@dnsmichi dnsmichi added the area/metrics General metrics handling label Feb 2, 2017
@dnsmichi dnsmichi added this to the 2.7.0 milestone Feb 2, 2017
@dnsmichi dnsmichi self-requested a review February 2, 2017 12:24
@dnsmichi
Copy link
Contributor

dnsmichi commented Feb 7, 2017

Thanks 👍

@dnsmichi dnsmichi closed this in 041772f Feb 7, 2017
gunnarbeutner pushed a commit that referenced this pull request May 16, 2017
@spjmurray @gunnarbeutner
PerfData: Server Timeouts for InfluxDB Writer
71b19ed 
Exposes the TCP socket used to communicate with the InfluxDB server.  When we are
expecing a response we can now call poll() on the socket to wait for data to become
available.  If it doesn't in a user configurable timeout period we abort the request.

fixes #4927
fixes #4941

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
@dnsmichi dnsmichi added the bug Something isn't working label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi Awaiting requested review from dnsmichi

Assignees

@spjmurray spjmurray

Labels
area/metrics General metrics handling bug Something isn't working
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spjmurray @dnsmichi