Improve InfluxdbWriter performance #5764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarbeutner
added
enhancement
dnsmichi
reviewed
Nov 15, 2017
lib/perfdata/influxdbwriter.cpp
Outdated
| } | ||
| } | ||
|
|
||
| msgbuf << " " << static_cast<unsigned long>(ts); | ||
|
|
||
| #ifdef _DEBUG |
dnsmichi
reviewed
Nov 15, 2017
lib/perfdata/influxdbwriter.cpp
Outdated
| } | ||
|
|
||
| double et = Utility::GetTime(); | ||
| Log(LogInformation, "InfluxDbWriter") |
There was a problem hiding this comment.
That might be too noisy as information level.
There was a problem hiding this comment.
Oops, that's not even meant to be there at all, at least not in the PR. 😇
|
That's de facto a rewrite of the InfluxDB feature. Must be tested with care before any release. |
gunnarbeutner
force-pushed
the
feature/influxdb-cleanup
branch
from
bca74ea
to
4764c03
Compare
|
Aye, this is definitely a major change. |
|
Backporting will be "funny" with the code quality changes applied in master. |
|
Backporting as per @lippserd's request. :) |
gunnarbeutner
force-pushed
the
feature/influxdb-cleanup
branch
from
4764c03
to
40f9431
Compare
This was referenced Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also depends on PR #5759 and #5760.