Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog.py: Adjust categories and labels: Enhancement, Bug, ITL, Documentation, Support #5989

Merged
merged 1 commit into from Jan 16, 2018

Conversation

dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented Jan 16, 2018

This PR allows to adjust the categories and matching labels. If no label
matches, "Support" is the old hardcoded default.

Issues with the "Documentation" and "ITL" label will be put into their
respective category at the bottom before "Support". This increases readability
and allows users to focus on the core vs additional config and docs.

"Support" also applies to labels such as "code-quality", "Tests" and "Packages"/"Installation".

Note: Labels are case sensitive. The order of the categories dictionary is
important too.

Since issues and PRs are the same for GitHub, and we don't require an issue
for a PR anymore, we sometimes have duplicates. This patch adds an inline
label called "PR" to highlight these PRs in the Changelog.

Example from Atom:
screen shot 2018-01-16 at 15 42 57

…cumentation, Support

This PR allows to adjust the categories and matching labels. If no label
matches, "Support" is the old hardcoded default.

Issues with the "Documentation" and "ITL" label will be put into their
respective category at the bottom before "Support". This increases readability
and allows users to focus on the core vs additional config and docs.

"Support" also applies to labels such as "code-quality", "Tests" and "Packages"/"Installation".

Note: Labels are case sensitive. The order of the categories dictionary is
important too.

Since issues and PRs are the same for GitHub, and we don't require an issue
for a PR anymore, we sometimes have duplicates. This patch adds an inline
label called "PR" to highlight these PRs in the Changelog.
@dnsmichi dnsmichi added this to the 2.8.1 milestone Jan 16, 2018
@dnsmichi dnsmichi self-assigned this Jan 16, 2018
@dnsmichi dnsmichi merged commit bea793d into master Jan 16, 2018
@dnsmichi dnsmichi deleted the feature/changelog-categories-labels branch January 16, 2018 15:02
dnsmichi pushed a commit that referenced this pull request Jan 16, 2018
…cumentation, Support

This PR allows to adjust the categories and matching labels. If no label
matches, "Support" is the old hardcoded default.

Issues with the "Documentation" and "ITL" label will be put into their
respective category at the bottom before "Support". This increases readability
and allows users to focus on the core vs additional config and docs.

"Support" also applies to labels such as "code-quality", "Tests" and "Packages"/"Installation".

Note: Labels are case sensitive. The order of the categories dictionary is
important too.

Since issues and PRs are the same for GitHub, and we don't require an issue
for a PR anymore, we sometimes have duplicates. This patch adds an inline
label called "PR" to highlight these PRs in the Changelog.

refs #5989
@dnsmichi dnsmichi added the backported Fix was included in a bugfix release label Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Fix was included in a bugfix release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant