New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for optionally specifying the 'var' keyword in 'for' loops #6110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👯♀️
From a first look, this makes it complicated to follow and understand e.g. apply for inside the monitoring basics chapter. Let's talk about this next week in the office :) |
It can be added, nevertheless we shouldn't change our entire documentation for it. If that's the requirement, I'd drop this feature as this makes it complicated for our users (who are not programmers). |
I guess I might reword this to drop all the docs changes (apart from the bit where we mention that users can optionally add |
2a4e485
to
2eb46f1
Compare
I've updated the PR to remove most of the controversial doc and example config changes. 🙂 |
Any objections to setting the target to 2.10? |
Looks good, thanks :) Review/merge happens after 2.9. |
This adds support for optionally using the
var
keyword in for loops:and
Adding the
var
keyword has no semantic effect other than unifying how we usually do variable declarations.