Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDO/MySQL: avoid empty queries #6530

Merged
merged 1 commit into from Aug 8, 2018
Merged

IDO/MySQL: avoid empty queries #6530

merged 1 commit into from Aug 8, 2018

Conversation

Al2Klimov
Copy link
Member

No description provided.

@Al2Klimov Al2Klimov requested a review from dnsmichi August 8, 2018 10:12
@Al2Klimov
Copy link
Member Author 

[2018-08-08 12:08:05 +0200] critical/IdoMysqlConnection: Error "Query was empty" when executing query ""

@Al2Klimov Al2Klimov mentioned this pull request Aug 8, 2018
Closed
@dnsmichi dnsmichi added bug Something isn't working area/db-ido Database output labels Aug 8, 2018
@dnsmichi dnsmichi added this to the 2.10.0 milestone Aug 8, 2018
@dnsmichi dnsmichi merged commit ba21a54 into master Aug 8, 2018
@dnsmichi dnsmichi deleted the bugfix/query-was-empty branch August 8, 2018 12:42
@Al2Klimov
Copy link
Member Author

Sigh Just got this error w/ v2.6.0 (from OS' package repos).

@Crunsher Any chance to include this in the next bugfix release (if it comes before v2.10)?

@Al2Klimov
Copy link
Member Author

Forget it. I've overseen yet another elephant and produced an insanely large plugin output 😫.

@dnsmichi
Copy link
Contributor

dnsmichi commented Sep 3, 2018

I'd prefer to keep this tested and released with 2.10. 2.9.2 should solely target the remaining tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi dnsmichi approved these changes

Assignees
No one assigned
Labels
area/db-ido Database output bug Something isn't working
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Al2Klimov @dnsmichi