New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icinga2 crashes after using some api-commands on Fedora 28 #6533
Comments
Crash-Report:
|
Hmmm unfortunately I'm not able to reproduce this on F28 here. The query you're firing against the API, how does it look exactly - only the URL or are there more parameters involved? I can see that the crash sources from Blind guess:
|
The crashing queries are exactly like under "Current Behavior", fired as bash-command:
The second command with a hostname at the end works fine:
|
In the meanwhile I tried to reproduce the problem on other machines.
Maybe there is a general problem with fedora at all?! |
@caregg Just to be sure: You create a fresh virtual machine in VMware Player with Fedora 28 and perform your four "Steps to Reproduce"... and it reliably doesn't work? |
Yes, exactly.
The result is:
|
Did you use the Fedora 27 repository? Because the Fedora 28 repository on packages.icinga.com is currently not available. I've tested this both with a manually build 2.9.1 and the Fedora 27 repository. I'll revisit this issue when our Fedora 28 repository is up and running. |
With the repository of Fedora 28. |
@caregg The F28 repo seems to ship packages again. Does the error still occur with fresh F28 packages? |
@Al2Klimov it does. Might be something packaging related. |
This happens on F28 only with gcc 8.1.1 and enabled https://bugzilla.redhat.com/show_bug.cgi?id=1515858 More references: I believe that std::emplace_back() with std::move() on an std::unique_ptr is a problem here.
|
For some reason, the debuginfo provided with the packages is scrambled and doesn't provide a full file table for the symbols. I've recompiled by source setup with the hardening flags and can now debug it way better.
std::move is not correct, it is about the Expression being a unique_ptr.
Apparently Proof: If you pass
The fix is not the best code, but actually we need to either check for a) |
The actual fix is to handle nullptr references differently for an empty filter expression. The other changes include oob checks not necesarily involved. fixes #6533
The actual fix is to handle nullptr references differently for an empty filter expression. The other changes include oob checks not necesarily involved. fixes #6533
@caregg can you test the snapshot packages? |
The problem disappeared in version 2.9.1-180 !!! |
Thanks, backported for 2.9.2 :) |
I am experiencing crashes while using the icinga-api. At first I notices it, after trying to install the icinga-director, the director-kickstarter got an "empty result", because icinga crashed.
But it's not necessary to install the director, the problem occurs much earlier...
Current Behavior
Some curl-commands let icinga crashing immediately. For example:
This commands are working:
Steps to Reproduce (for bugs)
Your Environment
icinga2 feature list
):icinga2 daemon -C
):Debug-Error-Message:
debug.log from daemon-start till crash:
The text was updated successfully, but these errors were encountered: