Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that config object types are committed in dependent load order #6568

Merged
merged 2 commits into from Sep 4, 2018
Merged

Ensure that config object types are committed in dependent load order #6568

merged 2 commits into from Sep 4, 2018

Conversation

Crunsher
Copy link
Contributor

@Crunsher Crunsher commented Aug 22, 2018 •
edited by dnsmichi

fixes #6540

@Crunsher Crunsher added this to the 2.9.2 milestone Aug 22, 2018
@Crunsher Crunsher mentioned this pull request Aug 31, 2018
Merged
@dnsmichi dnsmichi self-requested a review September 4, 2018 09:11
@dnsmichi dnsmichi added the area/configuration DSL, parser, compiler, error handling label Sep 4, 2018
@dnsmichi
Copy link
Contributor

dnsmichi commented Sep 4, 2018

Depends on #6581 which must be cherry-picked too.

@dnsmichi
Copy link
Contributor

dnsmichi commented Sep 4, 2018

The proper fix for this behaviour is to have a static defined commit order, similar to the activation priority. We'll evaluate this in a secondary PR, and only for 2.10.

I'm leaving the log messages to debug builds this time, this is something for a separate PR.

In my tests rebased on #6581 this patch basically stays the same, as can be seen in @Crunsher 's analysis. I'll approve this for 2.9.2.

@dnsmichi dnsmichi changed the title WIP: Ensure committing object types on load order Ensure that config object types are committed in dependent load order Sep 4, 2018
@dnsmichi dnsmichi added the enhancement New feature or request label Sep 4, 2018
@dnsmichi
Copy link
Contributor

dnsmichi commented Sep 4, 2018

I'm tagging this as an enhancement, nevertheless it will help resolve an issue with 2.9.1.

This was referenced Sep 4, 2018
Closed
Closed
@dnsmichi dnsmichi merged commit 18bf1ef into master Sep 4, 2018
@dnsmichi dnsmichi deleted the feature/commit-order branch September 4, 2018 11:39
dnsmichi pushed a commit that referenced this pull request Sep 20, 2018
@lazyfrosch
Ensure that config object types are committed in dependent load order
bd927f1 
refs #6568
dnsmichi pushed a commit that referenced this pull request Sep 20, 2018
@Crunsher
Update variable names
6f20749 
refs #6568
@dnsmichi dnsmichi added the backported Fix was included in a bugfix release label Sep 20, 2018
@Al2Klimov Al2Klimov mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi dnsmichi approved these changes

Assignees
No one assigned
Labels
area/configuration DSL, parser, compiler, error handling backported Fix was included in a bugfix release enhancement New feature or request
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

Evaluate a fixed config compiler commit order
3 participants
@Crunsher @dnsmichi @lazyfrosch