Add 'used' feature to check_swap #6651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crunsher
previously requested changes
Oct 5, 2018
This implements the _used_ feature to check_swap to print the used swap instead of the default available swap.
mcktr
force-pushed
the
feature/check-swap-show-used
branch
2 times, most recently
from
f520b36
to
f3d4850
Compare
|
Updated the ITL CheckCommand to include the new parameter. |
dnsmichi
suggested changes
Oct 8, 2018
itl/command-plugins-windows.conf
Outdated
| @@ -258,6 +258,10 @@ object CheckCommand "swap-windows" { | |||
| value = "$swap_win_unit$" | |||
| description = "Unit to display swap in" | |||
| } | |||
| "-U" = { | |||
| set_if = $swap_win_show_used$ | |||
There was a problem hiding this comment.
This breaks the config tests, missing double quotes.
mcktr
force-pushed
the
feature/check-swap-show-used
branch
from
14330dc
to
ad1ab42
Compare
|
Fixed the config test. Tests are now all green. |
dnsmichi
approved these changes
Oct 9, 2018
|
Thanks 👍 |
dnsmichi
added
area/windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the used feature to check_swap to print the used swap
instead of the default available swap.