Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check_memory thresholds in 'used' mode #6652

Merged
merged 1 commit into from Oct 8, 2018

Conversation

mcktr
Copy link
Member

@mcktr mcktr commented Oct 4, 2018

The thresholds in the used mode now breaks if the value is bigger than
the threshold.

Current behavior

.\check_memory.exe -U -w 90% -c 95%
MEMORY WARNING - 50.2983% used| 'memory'=2059.99MB;3685.9950000000003;3890.7725;0;4095.55

I expected that the threshold breaks if it where above 90%/95% . Currently the threshold breaks if it is below 90%/95%

 .\check_memory.exe -U -w 48% -c 30%
MEMORY OK - 49.2309% used| 'memory'=2016.28MB;1965.864;1228.665;0;4095.55

 .\check_memory.exe -U -w 50% -c 30%
MEMORY WARNING - 49.1621% used| 'memory'=2013.46MB;2047.7750000000001;1228.665;0;4095.55

Fixed behavior

.\check_memory.exe -U -w 90% -c 95%
MEMORY OK - 49.8562% used| 'memory'=2041.89MB;3685.9950000000003;3890.7725;0;4095.55

The threshold is correctly respected and breaks if it is above 90%/95%.

 .\check_memory.exe -U -w 50% -c 95%
MEMORY OK - 48.0606% used| 'memory'=1968.35MB;2047.7750000000001;3890.7725;0;4095.55

 .\check_memory.exe -U -w 47% -c 95%
MEMORY WARNING - 48.0603% used| 'memory'=1968.34MB;1924.9085;3890.7725;0;4095.55

The thresholds in the used mode now breaks if the value is bigger than
the threshold.
@mcktr mcktr added bug Something isn't working Plugins labels Oct 4, 2018
@mcktr mcktr requested a review from Crunsher October 4, 2018 09:20
@dnsmichi dnsmichi added this to the 2.10.0 milestone Oct 8, 2018
@dnsmichi dnsmichi merged commit f041115 into master Oct 8, 2018
@dnsmichi dnsmichi deleted the bugfix/check-memory-used-thresholds branch October 8, 2018 11:18
@dnsmichi dnsmichi added area/windows Windows agent and plugins and removed area/windows Windows agent and plugins labels May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows Windows agent and plugins bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants