Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB IDO: Don't enqueue queries when the feature is paused (HA) #6740

Merged
merged 1 commit into from Oct 30, 2018

Conversation

dnsmichi
Copy link
Contributor

fixes #5876
refs #6739

@dnsmichi dnsmichi added this to the 2.11.0 milestone Oct 30, 2018
@dnsmichi dnsmichi added bug Something isn't working area/db-ido Database output labels Oct 30, 2018
@dnsmichi dnsmichi merged commit 4050ca5 into master Oct 30, 2018
@dnsmichi dnsmichi deleted the bugfix/ido-paused-query-queue-no-enqueue branch October 30, 2018 12:40
@Mikesch-mp
Copy link
Contributor

What happens to the queue when it gets paused? will it be synced to other master or waits until it is not paused anymore?

@dnsmichi
Copy link
Contributor Author

Such queues cannot be synced, it stops when the feature is paused. This already is the case now, only the enqueues were wrong.

@Mikesch-mp
Copy link
Contributor

So all the data is lost?

@dnsmichi
Copy link
Contributor Author

There always is an overlap when one nodes decides to take over, causing the other one to pause. There's no data loss in between, and the stream from both instances is the same.

@dnsmichi dnsmichi modified the milestones: 2.11.0, 2.10.2 Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/db-ido Database output bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDO Work queue on the inactive node growing when switching connection between redundant master servers
2 participants