Initialize ICINGA2_ERROR_LOG inside the systemd environment

[dnsmichi]

The initscript uses a local default, which is not here for Systemd.

[dnsmichi]

I've tested this with the Debian 2.10.1 packages and a modified Systemd service file. Works fine thus far. Opinions on the variable default initializer @lazyfrosch @dgoetz ?

[lazyfrosch]

LGTM, Have you tested this on a CentOS 7?

[dnsmichi]

Not yet, I wanted to first check whether you like this fix :)

Done that now:

[root@icinga2-centos7-dev ~]# systemctl restart icinga2
[root@icinga2-centos7-dev ~]# ps aux | grep icinga2
icinga   27337 21.6  0.5 789956 15368 ?        Ssl  16:24   0:01 /usr/lib64/icinga2/sbin/icinga2 --no-stack-rlimit daemon --close-stdio -e
icinga   27376  0.0  0.0 456140  1756 ?        S    16:24   0:00 /usr/lib64/icinga2/sbin/icinga2 --no-stack-rlimit daemon --close-stdio -e
root     27386  0.0  0.0 112704   972 pts/0    S+   16:24   0:00 grep --color=auto icinga2

Applied the line in the service file (I am lazy testing, this is clearly not best practice).

vim /lib/systemd/system/icinga2.service

[Unit]
Description=Icinga host/service/network monitoring system
After=syslog.target network-online.target postgresql.service mariadb.service carbon-cache.service carbon-relay.service

[Service]
Type=notify
Environment="ICINGA2_ERROR_LOG=/var/log/icinga2/error.log"
EnvironmentFile=/etc/sysconfig/icinga2
ExecStartPre=/usr/lib/icinga2/prepare-dirs /etc/sysconfig/icinga2
ExecStart=/usr/sbin/icinga2 daemon --close-stdio -e ${ICINGA2_ERROR_LOG}
PIDFile=/run/icinga2/icinga2.pid
ExecReload=/usr/lib/icinga2/safe-reload /etc/sysconfig/icinga2
TimeoutStartSec=30m

systemctl daemon-reload

Result:

[root@icinga2-centos7-dev ~]# systemctl restart icinga2
[root@icinga2-centos7-dev ~]# ps aux | grep icinga2
icinga   27469 44.0  0.5 790604 15704 ?        Ssl  16:25   0:00 /usr/lib64/icinga2/sbin/icinga2 --no-stack-rlimit daemon --close-stdio -e /var/log/icinga2/error.log
icinga   27508  1.0  0.0 456140  1752 ?        S    16:25   0:00 /usr/lib64/icinga2/sbin/icinga2 --no-stack-rlimit daemon --close-stdio -e /var/log/icinga2/error.log