Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't delete downtimes in satellite zones #6821

Merged
merged 2 commits into from Dec 18, 2018
Merged

Don't delete downtimes in satellite zones #6821

merged 2 commits into from Dec 18, 2018

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Dec 4, 2018 •
edited

refs #6542

@Al2Klimov Al2Klimov self-assigned this Dec 4, 2018
@Al2Klimov
Copy link
Member Author

Al2Klimov commented Dec 4, 2018 •
edited

@dnsmichi Please review whether this would be the way to go – w/o proofs of concept or reproducing. If yes, please help me (offline) to get this actually working.

@Al2Klimov Al2Klimov mentioned this pull request Dec 5, 2018
Closed
@dnsmichi
Copy link
Contributor

dnsmichi commented Dec 7, 2018

This will likely solve case 2 here. I'm not yet sure whether it is needed @lippserd

img_2544

@Al2Klimov
Copy link
Member Author

If any satellite sends notifications, this is definitively needed.

@Al2Klimov
Copy link
Member Author

@dnsmichi For the sake of your defense: You didn't draw the cat – @theFeu did.

@Al2Klimov Al2Klimov force-pushed the bugfix/downtimes-disappear-satellite-6542 branch from a0a2008 to c98d6a5 Compare December 17, 2018 14:59
@Al2Klimov Al2Klimov changed the title WIP: Bugfix/downtimes disappear satellite 6542 Don't delete downtimes in satellite zones Dec 17, 2018
@Al2Klimov Al2Klimov removed their assignment Dec 17, 2018
@dnsmichi dnsmichi added this to the 2.10.3 milestone Dec 18, 2018
@dnsmichi dnsmichi added bug Something isn't working area/configuration DSL, parser, compiler, error handling labels Dec 18, 2018
@dnsmichi
Copy link
Contributor

Backport only when master-snapshot tests succeed.

@dnsmichi dnsmichi merged commit c4d57af into master Dec 18, 2018
@Al2Klimov Al2Klimov deleted the bugfix/downtimes-disappear-satellite-6542 branch December 18, 2018 15:26
@dnsmichi dnsmichi added area/distributed Distributed monitoring (master, satellites, clients) backported Fix was included in a bugfix release labels Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi dnsmichi approved these changes

Assignees
No one assigned
Labels
area/configuration DSL, parser, compiler, error handling area/distributed Distributed monitoring (master, satellites, clients) backported Fix was included in a bugfix release bug Something isn't working
Projects
None yet
Milestone
2.10.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Al2Klimov @dnsmichi