Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfluxdbWriter: don't leak sockets #6990

Merged
merged 2 commits into from Mar 18, 2019
Merged

InfluxdbWriter: don't leak sockets #6990

merged 2 commits into from Mar 18, 2019

Conversation

Al2Klimov
Copy link
Member

fixes #6989

@Al2Klimov Al2Klimov requested a review from N-o-X March 1, 2019 13:34
@Al2Klimov Al2Klimov mentioned this pull request Mar 6, 2019
Closed
@mcktr mcktr added the area/influxdb Metrics to InfluxDB label Mar 8, 2019
@Al2Klimov Al2Klimov requested review from dnsmichi and removed request for N-o-X March 11, 2019 09:43
@Al2Klimov Al2Klimov mentioned this pull request Mar 12, 2019
Closed
5 tasks
@carraroj
Copy link

ref/IP/12219

@Al2Klimov
Copy link
Member Author

The partner successfully tested this one and is expected to write a test protocol.

@dnsmichi dnsmichi added this to the 2.11.0 milestone Mar 13, 2019
@Al2Klimov
Copy link
Member Author

Test protocol

@latuannetnam latuannetnam mentioned this pull request Mar 15, 2019
Closed
@Al2Klimov Al2Klimov mentioned this pull request Mar 15, 2019
Merged
@dnsmichi dnsmichi added the bug Something isn't working label Mar 18, 2019
@dnsmichi
Copy link
Contributor

Merci, will test that one this week.

@dnsmichi
Copy link
Contributor

Reproducer and tests: #6989 (comment)

@dnsmichi dnsmichi merged commit 2de8bac into master Mar 18, 2019
@dnsmichi dnsmichi deleted the bugfix/influxdbwriter-oom-6989 branch March 18, 2019 13:38
@dnsmichi dnsmichi modified the milestones: 2.11.0, 2.10.4 Mar 19, 2019
@dnsmichi
Copy link
Contributor

Only picked 2a6b122 in support/2.10 since Defer was backported separately in #7032.

@dnsmichi dnsmichi added the backported Fix was included in a bugfix release label Mar 19, 2019
@dnsmichi dnsmichi mentioned this pull request Mar 21, 2019
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi dnsmichi approved these changes

Assignees
No one assigned
Labels
area/influxdb Metrics to InfluxDB backported Fix was included in a bugfix release bug Something isn't working ref/IP
Projects
None yet
Milestone
2.10.4
Development

Successfully merging this pull request may close these issues.

InfluxdbWriter not closing connections Icinga2 2.10.3 CentOS 7
4 participants
@Al2Klimov @carraroj @dnsmichi @mcktr