-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SSL connections #3
Comments
It seems like One solution is to loop until Another way, which seems to work (in a very limited test) is to use while true
r, _, _ = IO.select([c])
r && r.each do |s|
read_size = 2**16
data = ''
while read_size > 0
data << s.read_nonblock(read_size)
read_size = s.pending
end
# process data
end
end I.e. read an initial chunk, which is what we would have done anyway, and then read another chunk if |
Turns out that it's a bit more complicated: JRuby doesn't support |
Another fun fact: |
What's the most recent status on this issue? Are there any plans to merge it into master any time soon? Is there anything specific I could help with to make that happen? Thanks! |
I'd really like to, and if I get some help testing it I can get it out in v1.2, but as I said in iconara/cql-rb#110 I really need people to test it, and no one has stepped up. It's very hard to automate testing for this, and I just don't feel confident that the limited testing that I can do myself is enough. I'd like it for people who actually need to run Cassandra, for example, with encryption to test it and see that it works for them. |
Ok, that makes sense. I'm finally getting time to start looking at adding encryption to my project, so I'll definitely be pulling it in. I'm still on Cassandra 1.2 for now, but I don't think the encryption support has changed much between that and 2.0. I'll let you know what I find. Has the ssl_support branch been kept up to date with the other 1.2 changes? |
It should be fine to run cql-rb with the |
I just rebased |
And thanks for helping out! |
Thanks for the rebase. I was going to attempt it, but I'm far from familiar with the code. Integrating it now and will let you know what I find. |
For anyone else watching this, the SSL features have been released with v1.2.0.pre2 |
This has been released with v1.2.0. |
Just make sure that this is not an issue, but it actually looks ok.
The text was updated successfully, but these errors were encountered: