-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: add fluent-emoji from Microsoft #52
Comments
Awesome. I've seen PNG version of their new emoji few weeks ago, they look really good. Glad that they've made SVG available and in 3 versions! |
This might take a while. Icons are great, but don't pass validation because of some code that doesn't make any sense, such as <feFlood flood-opacity="0" result="BackgroundImageFix"/> Not sure what's going on there, need to re-check specification tomorrow. Maybe filters are bad, maybe I'm missing something in spec. Also few icons seem to have bad size instead of 32x32: microsoft/fluentui-emoji#34 |
From what I've quickly glanced, there will probably be some fixes coming soon (next month or so) to the overall project. Thanks for your reactivity btw! 🙏🏻 |
So I've fixed errors in my validator script and converted icon set. It is somewhat usable. Somewhat. In other emoji sets average icon size is about 2kb per icon, in simple icon sets such as Material Icons its below 500 bytes per icon. In Fluent Emoji average icon size is 30463 bytes! When showing 52 icons per page, page freezes for several seconds in Chrome. For each icon hover, it freezes again for a second. I've never seen such massive rendering lag. Issue is caused by huge amount of filters used in each icon, which takes massive amount of CPU time to render. I'll publish icon set, but for now it is unusable for websites. That's very unfortunate because icons are very cool. edit: actually, I've overreacted a bit. Sorry. Performance is not as bad as initially tested, so icons are usable. Running local version of API affected my tests. I suspect it has something to do with big JSON file loaded as is on API, which makes filtering icons memory intensive. API servers are definitely going to be suffering from this, but now I have discovered a weak point that needs to be addressed in next version, so it is good. |
Added! https://icon-sets.iconify.design/fluent-emoji/ I'll add flat and high contrast variations later this weekend. |
Damn amazing! Thank you very much. ♥ |
Added Unlike default set, these variations don't contain huge number of gradients and filters, so files are small. For flat average size is 2.8kb per icon, for high contrast its 1.7kb... compared to 30kb for default. High contrast is especially awesome to have because it is basically a good monotone icon set, but for emojis instead of general UI icons. Before this set, the only other monotone emoji set was outdated Emoji One version 1 set. |
Website has finally rebuilt. Icon sets are available here: |
It's brand new and a bit special but those are finally open-sourced and quite super cute. 👌🏻
https://github.com/microsoft/fluentui-emoji
The text was updated successfully, but these errors were encountered: