Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for react 17 #59

Closed
mjkl-gh opened this issue Feb 7, 2021 · 3 comments
Closed

Support for react 17 #59

mjkl-gh opened this issue Feb 7, 2021 · 3 comments

Comments

@mjkl-gh
Copy link

mjkl-gh commented Feb 7, 2021

First of all many thanks for developing this library. It's been of great use!

Unfortunately the base project I used for my project moved to React 17 recently. NPM install now returns:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: esp-dsmr@0.1.0
npm ERR! Found: react@17.0.1
npm ERR! node_modules/react
npm ERR!   react@"^17.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0" from @iconify/react@1.1.3
npm ERR! node_modules/@iconify/react
npm ERR!   @iconify/react@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 

Will this library support react 17 in the near future? Or is there something else I'm missing?

@cyberalien
Copy link
Member

Thanks!

It should work fine with 17. I guess it would be safe to just remove peer dependency and assume users do have some version of React installed without explicitly listing it in dependencies. I'll test it.

@cyberalien
Copy link
Member

Works fine without peer dependencies, so I've removed it. Tested with React 17, no issues.

Install @iconify/react@beta for latest version.

@cyberalien
Copy link
Member

Fixed in version 1 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants