Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon argument to getIdList() function. #67

Closed
4 tasks done
ZogopZ opened this issue Mar 30, 2022 · 0 comments · Fixed by #81
Closed
4 tasks done

Add icon argument to getIdList() function. #67

ZogopZ opened this issue Mar 30, 2022 · 0 comments · Fixed by #81
Assignees
Labels
feature New feature or request

Comments

@ZogopZ
Copy link
Member

ZogopZ commented Mar 30, 2022

Extend getIdList() function by adding an icon argument.
By default, when running:
station.getIdList(project='icos', outfmt='map') the code adds a country flag to each station's location.

  • Change default behavior to a folium's built-in default marker.
    station.getIdList(project='icos', outfmt='map')
  • Add functionality for custom user defined icon.
    station.getIdList(project='icos', outfmt='map', icon='/home/.../small_sized_image.png')
  • Keep the previous functionality when the user explicitly sets icon='flag'.
    station.getIdList(project='icos', outfmt='map', icon='flag')
  • Update pylib's documentation to include these changes.
@ZogopZ ZogopZ added the feature New feature or request label Mar 30, 2022
@ZogopZ ZogopZ self-assigned this Mar 30, 2022
@ZogopZ ZogopZ changed the title Add flag argument to getIdList() function. Add icon argument to getIdList() function. Apr 1, 2022
@ZogopZ ZogopZ linked a pull request Jun 14, 2022 that will close this issue
@ZogopZ ZogopZ mentioned this issue Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant