New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collection of parse errors from iCal ics files #369
Comments
Thanks!
|
@strobeflash would you mind running them via the code provided at #278 (comment) - afaik PRODID is a hard requirement as per the rfc so if that function works that'd leave just the malformed |
@introt indeed, except the empty SSTFTY20191231T052200.ics. thanks for the hint! A dummy PRODID to handle these cases sounds reasonable, with a warning on import. What do you think? NOK: D1618653-98A7-4108-8C7B-33181D1BE177.ics, couldn't find format matching '710394022147483642' (18 chars), tried {6: '%Y%m', 8: '%Y%m%d'} |
i also created a pull requestion for the bulk import script i used for future testing. |
I'd personally be against it - missing PRODIDs may be among the most common malformations out there, but they're only the tip of the invalid ics iceberg. I'm honestly surprised @diemoschwarz hasn't run into any missing END:VCALENDARs or nonstandard STATUSes. If ics-py were to parse non-compliant files, it should be implemented as a separate parse function with a distinct name (eg. |
Thanks a lot for taking care of this! I wouldn't mind either solution, as long as there is a clear and documented way for the user to specify a default PRODID, or simply a flag to provide one if missing.
Cheers! |
@diemoschwarz @strobeflash and @introt thank you for investigating this. It's great news that 0.8 seems to parse everything (modulo empty ones, missing prodids and the wierd date) FYI #278 is also talking about missing PRODID. Edit: if this subject gains interest, it might be a good time to reopen #236 and add those 60 example there too :) |
Hi, coming back to importing 1000s of ics files from iCal (see #290), I had these 60 files that produced errors with ics v0.7, from which 55 don't parse with ics==0.7.2 (from pip), Python 3.10.4 on MacOS 10.14.
I managed to extract and redact them here for a collection of test cases (see also #236): failed-redacted.zip
I hope this is still interesting and relevant to you. Thanks!
There are numerous
but also these errors:
and
which is simply due to the file being empty =-)
The full log:
The text was updated successfully, but these errors were encountered: