Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner filter -e tests equality instead of inclusion #45

Closed
spuun opened this issue Mar 24, 2022 · 0 comments
Closed

Runner filter -e tests equality instead of inclusion #45

spuun opened this issue Mar 24, 2022 · 0 comments
Assignees
@icy-arctic-fox
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@spuun
Copy link

spuun commented Mar 24, 2022

I believe this is a bug.

spectator/src/spectator/name_node_filter.cr

Lines 11 to 13 in 60085eb

def includes?(node) : Bool
@name == node.to_s
end

it should be @name.includes?(node.to_s)?
@icy-arctic-fox icy-arctic-fox self-assigned this Jul 13, 2022
@icy-arctic-fox icy-arctic-fox added bug Something isn't working good first issue Good for newcomers labels Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icy-arctic-fox icy-arctic-fox

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spuun @icy-arctic-fox