Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

Create ESLint autofix for eslint-plugin-react/jsx-first-prop-new-line #1

Closed
shioju opened this issue Sep 28, 2016 · 1 comment
Closed

Comments

@shioju
Copy link

shioju commented Sep 28, 2016

What we want

As a user, I want an autofix for the react/jsx-first-prop-new-line rule.

General acceptance criteria

Appropriate tests should be written for each additional feature.

Any additional code must not break the CI for any build configuration.

As we do not own the project, the task is considered done once your pull request has been merged into idagds/eslint-plugin-react. To benefit the rest of the open source community, we strongly encourage you to also submit a pull request to yannickcr/eslint-plugin-react.

Additional information

Developer guide for writing an autofix

@shioju shioju closed this as completed in 0771c11 Oct 4, 2016
shioju pushed a commit that referenced this issue Nov 2, 2016
@snowypowers
Copy link

hi FYI, the pull request for this fix is merged into the parent repo but contains adjustments of their opinion.
They did not want an indentation fix and felt that running the linter a second time to fix the indentation was ok. If you all are going to merge from parent, please note that the arguments remain as original (one for style).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants