Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Parse data libraries by true library and temperature. #21

Open
MicahGale opened this issue Feb 7, 2022 · 10 comments
Open

Feature: Parse data libraries by true library and temperature. #21

MicahGale opened this issue Feb 7, 2022 · 10 comments
Assignees
Labels
feature request An issue that improves the user interface. good first issue Good for newcomers
Milestone

Comments

@MicahGale
Copy link
Collaborator

Make so that it can be understand that 80c is ENDF/B-VII.1 at room temp. This way you can either change libraries and preserve temperature or preserve temperature and change libraries.

@MicahGale
Copy link
Collaborator Author

created branch 14-feature-parse-data-libraries-by-true-library-and-temperature to address this issue

@MicahGale
Copy link
Collaborator Author

@BrennaCarbno when you can create a draft merge request for this based off of develop, and tag this issue (#14).

To summarize:

  1. MCNPy should know:
    1. The nuclear data library the data is from (e.g., ENDF/B-VIII.0),
    2. The temperature of the data,
    3. and the type of data (e.g., continuous energy neutron cross-sections, versus discrete-energy Photoatomic data, etc.)
  2. This will require new object classes, so let's make an object model.
  3. We may want to change how the Material object stores data to be more use friendly, but that's not essential for this.

When you have a good idea of how you want to tackle this let's have a review meeting with (@BrennaCarbno, @tjlaboss, and @MicahGale).

@MicahGale
Copy link
Collaborator Author

Remember: users can modify their XSDIR and change their suffixes.

@MicahGale
Copy link
Collaborator Author

From meeting next actions:

  1. Parse whole core model with wrapper script
  2. Add support for XSDIR maybe? (concerned about EC restrictions on format)
  3. Add xsdir parser like: mcnpy.read_xsdir
  4. Map xsdir to materials.

Default behavior without XSDIR file? Default to LANL document, and raise a warning.

@MicahGale
Copy link
Collaborator Author

Also should implement #71 concurrently.

@MicahGale
Copy link
Collaborator Author

In GitLab by @tjlaboss on Feb 21, 2023, 15:20

  1. LANL has made all that stuff public.

https://github.com/nucleardata/DataListing https://nucleardata.lanl.gov/files/la-ur-08-1999.pdf

@MicahGale
Copy link
Collaborator Author

Ok yeah so definitely no EC concerns. But I think reading XSDIR is the best idea.

Side: why did they bake Jupyter into that tool?

@MicahGale
Copy link
Collaborator Author

WWWhhhhyyyy?

@MicahGale
Copy link
Collaborator Author

In GitLab by @tjlaboss on Feb 21, 2023, 16:28

LANL Did Something

@MicahGale
Copy link
Collaborator Author

marked this issue as related to #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request An issue that improves the user interface. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants