Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of "master/slave" notation for member variables and objects #15

Closed
moosebuild opened this issue Dec 14, 2021 · 2 comments
Closed
Assignees

Comments

@moosebuild
Copy link

In GitLab by @cticenhour on Dec 14, 2021, 15:50

This issue is a reproduction of the archived freya#11 for SQA purposes. Please refer to that issue for any extended discussion that may exist beyond this description.

Reason

Prompted by recent MOOSE and societal discussions, it's more important than ever to address old patterns and conventions of our work and make changes that get us to a point of technical clarity while also achieving inclusion for those who develop on our code base. "master/slave" naming conventions for objects and member variables is something that must be addressed.

Design

Removal of "master" and "slave" in all Freya objects, if used, and replacement with something like "primary" and "secondary". "neighbor" seems to be the currently used paired name in Freya to "master", and this may be better suited to becoming "secondary" if "primary" is chosen. A change to "neighbor" is therefore somewhat optional.

Impact

No functionality change...only changes to documentation, parameter names, and class member names.

@moosebuild
Copy link
Author

In GitLab by @cticenhour on Jul 14, 2022, 16:13

mentioned in commit 733976f

@moosebuild
Copy link
Author

In GitLab by @sapitts on Jul 14, 2022, 16:13

mentioned in commit 2908ec2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants