Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Baldr code to MALAMUTE [!6 merged] #42

Closed
moosebuild opened this issue Dec 23, 2021 · 18 comments
Closed

Add Baldr code to MALAMUTE [!6 merged] #42

moosebuild opened this issue Dec 23, 2021 · 18 comments
Assignees

Comments

@moosebuild
Copy link

In GitLab by @cticenhour on Dec 23, 2021, 14:50

Merges integrate-baldr -> devel

This MR adds code formerly residing in Baldr to MALAMUTE. The MALAMUTE Makefile was also updated to accommodate the new code and new module dependencies.

Note: Baldr tests fail with the current MOOSE submodule version, so they are skipped for now until they can be fixed. This requires a drop in the minimum coverage until they are fixed up.

Refs #5

@moosebuild
Copy link
Author

In GitLab by @cticenhour on Dec 23, 2021, 14:53

added 1 commit

Compare with previous version

@moosebuild
Copy link
Author

In GitLab by @cticenhour on Dec 23, 2021, 14:53

marked this merge request as ready

@moosebuild
Copy link
Author

CIVET Testing summary for 778bcc0

Precheck : Failed : Pre test
Documentation : Canceled by user
Mac Test : Canceled by user
Test : Canceled by user
Test Debug : Canceled by user
Non unity build : Canceled by user
Coverage : Canceled by user

@moosebuild
Copy link
Author

In GitLab by @cticenhour on Dec 23, 2021, 15:31

added 1 commit

Compare with previous version

@moosebuild
Copy link
Author

Job Precheck on ec2c223 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/malamute/docs/PRs/6/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 1879fb9c9470bae21fef77abb4a0105bf71d40d9

@moosebuild
Copy link
Author

CIVET Testing summary for ec2c223

Precheck : Failed : Format Check Clang 10.0
Documentation : Canceled by user
Mac Test : Canceled by user
Test : Canceled by user
Test Debug : Canceled by user
Non unity build : Canceled by user
Coverage : Canceled by user

@moosebuild
Copy link
Author

In GitLab by @cticenhour on Dec 23, 2021, 15:33

added 1 commit

Compare with previous version

@moosebuild
Copy link
Author

Job Coverage on 1d81614 wanted to post the following:

Coverage

1879fb #6 1d8161
Total Total +/- New
Rate 95.73% 67.58% -28.15% 37.92%
Hits 359 494 +135 135
Misses 16 237 +221 221

Diff coverage report

Full coverage report

Warnings

  • New new line coverage rate 37.92% is less than the suggested 90.0%

This comment will be updated on new commits.

@moosebuild
Copy link
Author

Job Documentation on 1d81614 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Author

CIVET Testing summary for 9589153

Precheck : Passed
Documentation : Failed : Build Docs
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Coverage : Failed : verify coverage

@moosebuild
Copy link
Author

In GitLab by @cticenhour on Dec 23, 2021, 16:20

added 2 commits

Compare with previous version

@moosebuild
Copy link
Author

CIVET Testing summary for 0b9e3da

Precheck : Passed
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Coverage : Allowed to fail : generate coverage

@moosebuild
Copy link
Author

In GitLab by @cticenhour on Dec 23, 2021, 18:09

requested review from @lindsayad

@moosebuild
Copy link
Author

In GitLab by @cticenhour on Dec 23, 2021, 18:35

added 82 commits

Compare with previous version

@moosebuild
Copy link
Author

In GitLab by @lindsayad on Dec 23, 2021, 18:56

approved this merge request

@moosebuild
Copy link
Author

In GitLab by @lindsayad on Dec 23, 2021, 18:56

enabled an automatic merge when the pipeline for 1d81614 succeeds

@moosebuild
Copy link
Author

CIVET Testing summary for 1d81614

Precheck : Passed
Documentation : Passed
Mac Test : Passed
Test : Passed
Test Debug : Passed
Non unity build : Passed
Coverage : Allowed to fail : generate coverage

@moosebuild
Copy link
Author

In GitLab by @lindsayad on Dec 23, 2021, 19:05

mentioned in commit 9953cd5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants