Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalXML efficiency and generality #47

Closed
10 tasks
PaulTalbot-INL opened this issue Apr 6, 2017 · 2 comments
Closed
10 tasks

ExternalXML efficiency and generality #47

PaulTalbot-INL opened this issue Apr 6, 2017 · 2 comments
Labels
archive To archive the feature requests or PRs when there are no further developments

Comments

@PaulTalbot-INL
Copy link
Collaborator

ExternalXML algorithms currently restart the search through all the XML nodes in the input whenever an ExternalXML node is discovered. This is required because of how xml.etree.ElementTree.Element.iter() works, as it kills the tree when the tree is modified.

This efficiency could be improved by finding a workaround to loop over an unmodified deepcopy of the tree, and analyze each new ExternalXML import for additional ExternalXML nodes, instead of the current approach.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@wangcj05 wangcj05 added archive To archive the feature requests or PRs when there are no further developments labels May 24, 2022
@wangcj05
Copy link
Collaborator

archived

1 similar comment
@wangcj05
Copy link
Collaborator

archived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive To archive the feature requests or PRs when there are no further developments
Projects
None yet
Development

No branches or pull requests

2 participants