Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Win test #982

Closed
9 of 10 tasks
alfoa opened this issue May 8, 2019 · 2 comments · Fixed by #983
Closed
9 of 10 tasks

Fix some Win test #982

alfoa opened this issue May 8, 2019 · 2 comments · Fixed by #983
Assignees
Labels

Comments

@alfoa
Copy link
Collaborator

alfoa commented May 8, 2019


Issue Description

What did you expect to see happen?

The new installation of Win caused some tests to fail (in local machines).
This should be addressed

What did you see instead?

The new installation procedure will be setup in the regression machine as well so the fixes
will be tested there

Do you have a suggested fix for the development team?

explicitly call bash.exe and python in case of Win

Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@alfoa alfoa mentioned this issue May 8, 2019
9 tasks
@alfoa alfoa self-assigned this May 9, 2019
@alfoa alfoa added defect devel issues in current devel priority_critical labels May 9, 2019
@mandd
Copy link
Collaborator

mandd commented May 9, 2019

Was an email sent to the users to alter them about this issue?

@PaulTalbot-INL
Copy link
Collaborator

Since limited tests were failing (not producing incorrect results), in my estimation a notification to the user base is not necessary for this issue.

Approved to close via #983.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants