-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect uri on error raise #164
Conversation
Looks good but I think we should take it one step further. I think having the collected request parameters available in all OAuth2Error exceptions would be helpful, if not for anything else but debugging. Maybe pass in a keyword arg request that we extract client_id, redirect_uri, scopes etc from?
|
Oh, that would be nice. |
Let's start with cherry picking a few and add more as we find it helpful. Start with If we add |
👍 Fully agree with you! I can update this pull req or create a new one if you prefer |
Whatever you prefer =) A new will make for a slightly cleaner commit log but that is a minor issue imo. |
I love clean logs so i'll go with a new pr. Back in 10 minutes |
This is a proposal to solve Issue #162