Redirect uri on error raise

[synasius]

This is a proposal to solve Issue #162

[coveralls]

Coverage remained the same when pulling 83f18d7 on synasius:redirect-uri-error into 21d31ee on idan:master.

[coveralls]

Coverage increased (+0%) when pulling 83f18d7 on synasius:redirect-uri-error into 21d31ee on idan:master.

[ib-lundgren]

Looks good but I think we should take it one step further. I think having the collected request parameters available in all OAuth2Error exceptions would be helpful, if not for anything else but debugging.

Maybe pass in a keyword arg request that we extract client_id, redirect_uri, scopes etc from?

class OAuth2Error(Exception):
  error = None

  def __init__(self, description=None, uri=None, state=None, status_code=400, request=None):
    ...
    if request:
      self.redirect_uri = request.redirect_uri
      etc.

[synasius]

Oh, that would be nice.
Would you like to unpack all the params collected in request._params or only some?

[ib-lundgren]

Let's start with cherry picking a few and add more as we find it helpful. Start with client_id, redirect_uri, scopes, response_type and grant_type maybe? Feel free to add more as you see fit.

If we add code or a flavour of token we should probably make sure they are not accidentally logged anywhere, don't think that is the case though.

[synasius]

👍 Fully agree with you! I can update this pull req or create a new one if you prefer

[ib-lundgren]

Whatever you prefer =) A new will make for a slightly cleaner commit log but that is a minor issue imo.

[synasius]

I love clean logs so i'll go with a new pr. Back in 10 minutes