Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 API cleanup to match OAuth1. Proposal for Issue #200 #201

Merged
merged 1 commit into from
Aug 3, 2013
Merged

OAuth2 API cleanup to match OAuth1. Proposal for Issue #200 #201

merged 1 commit into from
Aug 3, 2013

Conversation

squirly
Copy link
Contributor

@squirly squirly commented Aug 1, 2013

See #200

@lepture
Copy link
Collaborator

lepture commented Aug 2, 2013

Objection! This patch changed all returned values, it will break libraries relied on oauthlib.

@squirly
Copy link
Contributor Author

squirly commented Aug 2, 2013

Hence 0.* release codes. See http://semver.org/ point 4.

@ib-lundgren
Copy link
Collaborator

@lepture @synasius you are the main users that I know of of the provider. What approach to making this change would work best for you? I think having the redirection in the location cleaner maps to an actual response than dedicating one of the return values to the redirect URI and would be a better approach moving forward.

@squirly yes oauthlib is not stable but rather not break libraries out of the blue so will need to roll this out with some caution.

@lepture
Copy link
Collaborator

lepture commented Aug 2, 2013

@ib-lundgren I've thought about it. It will not take much work for this. Put the URI in headers is much nicer.

I think I would agree with @squirly

@synasius
Copy link
Contributor

synasius commented Aug 2, 2013

Love it! 👍 for the URI in the headers dict :).

I think having the redirection in the location cleaner maps to an actual response than dedicating one of the return values to the redirect URI and would be a better approach moving forward.

Totally agree

Integration with django-oauth-toolkit should be straightforward!

Thanks for your work guys

lepture added a commit to lepture/flask-oauthlib that referenced this pull request Aug 2, 2013
@lepture
works with new proposal of oauthlib/oauthlib#201 now
870aab2
@squirly
Copy link
Contributor Author

squirly commented Aug 2, 2013

If anyone does not have time to integrate the changes I'd be more than happy to help.

@ib-lundgren
Copy link
Collaborator

@squirly great work!

ib-lundgren added a commit that referenced this pull request Aug 3, 2013
@ib-lundgren
Merge pull request #201 from squirly/#200
1122945 
OAuth2 API cleanup to match OAuth1. Proposal for Issue #200
@ib-lundgren ib-lundgren merged commit 1122945 into oauthlib:master Aug 3, 2013
@squirly squirly deleted the #200 branch August 5, 2013 04:13
mvexel added a commit to mvexel/flask-oauthlib that referenced this pull request Aug 19, 2013
@mvexel
Merge remote-tracking branch 'upstream/master'
6c212a3 
* upstream/master:
  Changelog for 0.3.0-dev
  Backward compatible for lower version of Flask. #37
  Add badge of pypi version. Fix typo on OAuth1 server.
  linkedin works. another non-standard oauth2 service.
  works with new proposal of oauthlib/oauthlib#201 now
  add example for linkedin
  fix for lint
  use create_response method
  my mistake for get property
  pre configuration for #34
  bugfix get property for client
  change twitter to 1.1
  make utils public
  improve doc strings of the module
  Wrapped rv.data with to_unicode
  Created test for bad user credentials. Also updated usergetter to query the database for the given username instead of just returning the first record.
  Now checks to make sure user isn\'t None
@ib-lundgren
Copy link
Collaborator

@synasius @lepture This changes are now on PyPI as 0.6, sorry it took so long. Happy hacking!

@synasius
Copy link
Contributor

fine! I'm going to merge my refactor branch and release

2013/9/13 Ib Lundgren notifications@github.com

@synasius https://github.com/synasius @lepturehttps://github.com/leptureThis changes are now on PyPI as 0.6, sorry it took so long. Happy hacking!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/201#issuecomment-24384902
.

Federico Frenguelli

@lepture
Copy link
Collaborator

lepture commented Sep 13, 2013

@ib-lundgren I've already implemented the changes.

@ib-lundgren
Copy link
Collaborator

@synasius 🍰
@lepture 🍰

mattjweb added a commit to mattjweb/django-oauth-toolkit that referenced this pull request Mar 21, 2021
@mattjweb
Fix to match what reported in oauthlib/oauthlib#201
db992d1
sheriffwoody0922 added a commit to sheriffwoody0922/oauth-python-django that referenced this pull request Feb 1, 2024
@sheriffwoody0922
Fix to match what reported in oauthlib/oauthlib#201
7491245
codemachine0313 added a commit to codemachine0313/django-oauth-toolkit that referenced this pull request Apr 27, 2024
@codemachine0313
Fix to match what reported in oauthlib/oauthlib#201
756249f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@squirly @lepture @ib-lundgren @synasius