Ask validator if Client has to be authenticated #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'in authenticate_client.') | ||
| else: | ||
| log.debug('Client authentication disabled, %r.', request) | ||
| elif not self.request_validator.authenticate_client_id(request.client_id, request): |
There was a problem hiding this comment.
Nice that you added this in there, uncertain why it never got there in the first place. I probably just missed it in the spec.
|
Great work @masci |
ib-lundgren
added a commit
that referenced
this pull request
Sep 18, 2013
Ask validator if Client has to be authenticated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a proof of concept, I tried to uniform the logic for the three grants involved with Client authentication and make it generic enough for final users to decide if and how authenticate Clients through the validator.