Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSFW filter to usernames. #7

Closed
stemount opened this issue Nov 1, 2020 · 2 comments
Closed

Add NSFW filter to usernames. #7

stemount opened this issue Nov 1, 2020 · 2 comments

Comments

@stemount
Copy link

stemount commented Nov 1, 2020

Relates to ide-stories/vscode-stories#22 however this issue is in the wrong API cc @benawad @HariAcidReign @YashMunjal

Acceptance Criteria

  • Profanity filter on usernames has some tests
    -- The tests could be quite a fun test run "When some pillock tries to set username as Sh1tbagDeveloper"
  • Find a library off the shelf ideally that has an epic filter over a regex ideally...

Implementation notes

  • There are ways to implement unsafe regex so this must be considered for security scrutiny when the PR is open.
  • Might be worth "upping" the rate limiting (if there is any) on setting a username to prevent somebody trying a dictionary/wordlist of profanity.
@stemount
Copy link
Author

stemount commented Nov 1, 2020

@HariAcidReign @YashMunjal
There is also note that this is sort of fixed by the idea of social login because it would mean it would be an arduous process to just create GitHub/MS accounts with daft usernames. cc @benawad for priority/appetite to do social login

@benawad
Copy link
Contributor

benawad commented Nov 1, 2020

yeah I switched it over to github login, so I don't think we need to worry about this anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants